Richard Brooksby
Richard Brooksby
A couple of thoughts: 1. [proc.review.log](https://github.com/Ravenbrook/mps/blob/586336a7021c2276a3f798ad10e6e4ab5f438226/procedure/review.rst#55-review-logging) does not explicitly state the purpose of logging, at least part of which is to make the issues clear to proc.role.editor. 2. We could...
[llvm-diff](https://www.llvm.org/docs/CommandGuide/llvm-diff.html) could be used to detect changes to functions, using clang to generate intermediate code. A quick test on my Ubuntu 22 looked promising. Use `clang -S -emit-llvm` to generate...
> [llvm-diff](https://www.llvm.org/docs/CommandGuide/llvm-diff.html) could be used to detect changes to functions Hax. I put the following script in a file called git-lldiff: ``` #!/bin/bash case "$1" in *.c) llvm-diff-14 \
> It's far from perfect because it uses the _current_ contents of the code directory EDIT: Don't use this hack. See https://github.com/Ravenbrook/mps/blob/branch/2023-02-24/risk-tool/tool/git-fundiff Late night hax. This in git-lldiff: ``` #!/bin/bash...
Unfortunately llvm-diff isn't very good. It reports changes to functions even when comparing a file with itself, e.g. `llvm-diff x x`. Submitted https://github.com/llvm/llvm-project/issues/60993
The architecture code selects architecture-specific code for things like stack scanning and the mutator context. See for example [prmclii6.c](https://github.com/Ravenbrook/mps/blob/e179634de028b2db090ee6a2358391155102b74f/code/prmclii6.c) . So if there is likely to be more than one...
[mps.c](https://github.com/Ravenbrook/mps/blob/e179634de028b2db090ee6a2358391155102b74f/code/mps.c) spells out how source code is selected based on platform code. You'll be adding sets to that.
I note that [Porting the MPS](https://memory-pool-system.readthedocs.io/en/latest/topic/porting.html#porting-the-mps) doesn't mention CI and we definitely want CI coverage.
Great! If you have a working branch in a fork you could make a draft pull request to show stuff if you like.
> The main one here that impacts this now is that `setjmp` is not supported yet. This is used as part of stack scanning in `ss.h` (mps.design.stack-scan). See #38 and...