Richard Brooksby
Richard Brooksby
> After applying the above patch (not sure it is correct), I retried to build, also failed with the similar error. Nice try! :) Just for the record, that patch...
> In GitHub Actions, `ubuntu-latest` should have `gcc-12` / `g++-12` available and you can test multiple versions using a matrix. (It should have gcc 9, 10, 11, and 12 as...
@topazus https://github.com/Ravenbrook/mps/pull/257/commits/8e117ae69ea8a8017a0586569146b133786bf1ac (in #257 ) resolves warning on GCC 12.2.0 and GCC 13.0.1, passing `make test`. I am not able to reproduce the error in your original post on Ubuntu....
> I opened #258 to add Fedora CI which will reproduce the error. The build log of github workflow: https://github.com/topazus/mps/actions/runs/5636841949/job/15269323018 Thank you. We'll consider integrating this into our usual CI...
I found the [Fedora nightly compose finder](https://openqa.fedoraproject.org/nightlies.html) which provided [Fedora-Everything-netinst-x86_64-Rawhide-20230724.n.0.iso](https://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20230724.n.0/compose/Everything/x86_64/iso/Fedora-Everything-netinst-x86_64-Rawhide-20230724.n.0.iso) from which I was able to create a VM. The GCC version is 13.1.1. I was able to reproduce the...
> For the time being, we may add the `-Wno-error=dangling-pointer` to compiler flag, which can convert this error reporting to warning for further compiling. Please consider that unless you are...
A quick reproduction using an LXD container (in my case on Ubuntu 22): ``` lxc launch images:ubuntu/23.10 mps-ubuntu-mantic lxc shell mps-ubuntu-mantic apt-get update apt-get install -y git gcc make sudo...
It looks like the regression was introduced by me in https://github.com/Ravenbrook/mps/commit/2b108121b5971a295a4f04e91a72669ccde2cbb3
[design.mps.walk.case](https://github.com/Ravenbrook/mps/blob/edcc10d89aeb01035fcf9802170ed90f977b72f2/design/walk.txt) is an excellent template to follow for a section in design.mps.transform.
[TargetArch.cmake](https://github.com/Ravenbrook/mps/blob/2ab9015214ce2e6815a3fff3e73b79cfe39719e2/code/TargetArch.cmake) resembles [mpstd.h](https://github.com/Ravenbrook/mps/blob/branch/2023-02-10/cmake/code/mpstd.h). Perhaps we could use the latter to achieve the same result, so that we don't duplicate code.