rpmlint icon indicating copy to clipboard operation
rpmlint copied to clipboard

%mklibname check is not generic

Open scop opened this issue 12 years ago • 4 comments

(From http://rpmlint.zarb.org/cgi-bin/trac.cgi/ticket/7)

%mklibname is not something that's available everywhere, but is Mandriva specific, I believe. Distro specific stuff is being purged from the generic codebase, so this stuff could go while at it.

misc:

Yes I agree, but moving it outside would require the creation of a dedicated module outside of rpmlint current svn, which would lead to code duplication, ( spec file parsing, and reading ), or that we add some extension system ( class inheritance would be nice )

Given the fact it can be easily ignored at the moment, i prefer delay the resolution after the next release, if possible.

[email protected]:

Sure, no need to delay 0.7.6 for this.

Original comment by: scop

scop avatar Dec 06 '12 09:12 scop

Hi, @scop Do you think as of now, E: lib-package-without-%mklibname can be dropped in the rpmlint?

thisisshub avatar Jun 25 '20 04:06 thisisshub

It's been years since I've used rpmlint, so I have no opinion.

scop avatar Jun 25 '20 19:06 scop

The %mklibname check could be rejiggered to be a generic check if it didn't reference the macro. We can also switch the rule on by default if we did.

Conan-Kudo avatar Jun 25 '20 19:06 Conan-Kudo

It could be integrated to the slpp checker i am VERY slowly rewritting in #421 if anything. Atm I am just looking on what it actually was supposed to do and how to achieve that as it threw ton of false positives which is no good. But limiting factor is having time to do it of course.

scarabeusiv avatar Jun 26 '20 06:06 scarabeusiv