rpmlint icon indicating copy to clipboard operation
rpmlint copied to clipboard

Review and convert the check logic to use functionalized approach

Open scarabeusiv opened this issue 6 years ago • 2 comments

The tests for individual issues should be separated as much as possible to be later paralelized.

All the tests should be reviewed and verified they are in good shape. Also with this logic we should have at least 1 testcase per the function to make sure we do not regress to much.

Here is a list of current tests to review (new ones will hopefully be reviewed prior addition and adhere to this 'requirement):

  • [x] AbstractCheck.py
  • [x] AppDataCheck.py
  • [x] BinariesCheck.py
  • [x] ConfigCheck.py
  • [x] DistributionCheck.py
  • [x] DocFilesCheck.py
  • [x] FHSCheck.py
  • [ ] FilesCheck.py
  • [x] InitScriptCheck.py
  • [ ] I18NCheck.py
  • [x] LSBCheck.py
  • [ ] MenuCheck.py
  • [x] MenuXDGCheck.py
  • [x] NamingPolicyCheck.py
  • [x] PamCheck.py
  • [ ] PostCheck.py
  • [x] RpmFileCheck.py
  • [x] SCLCheck.py
  • [ ] SignatureCheck.py
  • [x] SourceCheck.py
  • [ ] SpecCheck.py
  • [ ] TagsCheck.py
  • [x] ZipCheck.py

scarabeusiv avatar Jul 26 '19 13:07 scarabeusiv

This seems to be a candidate for milestone 2.1. I don't see it fundamental for 2.0 release.

marxin avatar Sep 03 '19 08:09 marxin

(Just commenting on this so Tomas can assign this issue to me)

kstreitova avatar Sep 18 '19 14:09 kstreitova