libdnf icon indicating copy to clipboard operation
libdnf copied to clipboard

hawkey docs need to document the removal of hawkey.Repo

Open bowlofeggs opened this issue 6 years ago • 2 comments

While trying to solve https://github.com/fedora-infra/bodhi/issues/3193 today, I found that the hawkey tutorial still teaches users about the removed hawkey.Repo API: https://hawkey.readthedocs.io/en/latest/tutorial-py.html#loading-repositories

I also noticed that the hawkey changelog does not mention the removal of hawkey.Repo. It should also document a migration path for users who use that API.

Until this ticket is done, I would appreciate advice about how to get Bodhi to work with the new version of hawkey for the code here: https://github.com/fedora-infra/bodhi/blob/cb07ce2c82385a186245f1c6dbef0c2f2566f0e2/bodhi/server/util.py#L274 — if you could drop a comment over on the Bodhi issue that would be very helpful!

bowlofeggs avatar Apr 29 '19 20:04 bowlofeggs

FWIW, the upstream commit that removed it replaced all uses of it with uses of libdnf's Repo:

https://github.com/rpm-software-management/libdnf/commit/d59758ef2323a001c3a93b81b1afd0a2cb4f46d0

so I guess that's what you're supposed to do? You might be able to crib the necessary changes from that, I guess.

AdamWill avatar May 02 '19 02:05 AdamWill

@AdamWill I did actually try to go that route, but that API doesn't seem to be equivalent for Bodhi's use case. I also was told by the dnf team that there isn't an API that does what Bodhi was using it for. However, they are working on bringing the API I use back, so that's good!

bowlofeggs avatar May 02 '19 15:05 bowlofeggs