createrepo_c icon indicating copy to clipboard operation
createrepo_c copied to clipboard

Drop `--database` and `--no-database`, split?/drop `sqliterepo_c`

Open kontura opened this issue 1 year ago • 5 comments

  • The --database and --no-database options could be dropped entirely in favor of users deliberately calling sqliterepo_c

    • EL7 is the only significant beneficiary, and EL7 will be EOL in a year
    • As per the proposal that was submitted to fedora-devel, createrepo_c would not necessarily generate EL7-compatible repos by default due to the treatment of comps metadata anyway - this would be an even less disruptive than that as yum is perfectly capable of handling repos without sqlite metadata, it is merely preferred if present.
  • sqliterepo_c could be split into a new package so that it could be dropped at some point in the future without breaking createrepo_c's semantic versioning

    • Or maybe it makes sense to just remove entirely, now, as per the above points? Splitting the package off is just a conservative option.

Pulp currently does use createrepo_c's sqlite metadata support, but we're going to drop it in the near future.

Originally posted by @dralley in https://github.com/rpm-software-management/createrepo_c/issues/338#issuecomment-1525805415

kontura avatar Aug 08 '23 05:08 kontura

What would be benefit of the split?

j-mracek avatar Aug 08 '23 08:08 j-mracek

so that it could be dropped at some point in the future without breaking createrepo_c's semantic versioning

I think that was written before the point where you mentioned that we'd probably just do a 2.0 in a couple of years, though, and it wouldn't be a big deal.

dralley avatar Aug 08 '23 15:08 dralley

I suggest to deliver the change with 2.0 version.

j-mracek avatar Aug 22 '23 12:08 j-mracek

@j-mracek Do you want to have a deprecation warning on --database before then, or just drop it.

dralley avatar Aug 22 '23 15:08 dralley

Documented deprecation without warning is a good first step.

j-mracek avatar Aug 23 '23 15:08 j-mracek