react-uploady icon indicating copy to clipboard operation
react-uploady copied to clipboard

Initial Post Request doesnt set header "Upload-Concat": "partial" when parallel is >1

Open mariusschroeterCP opened this issue 10 months ago • 2 comments

We are using an implementation of the tusdotnet package as our tus server.

When uploading a new video file from the client with react-uploady with following settings:

<TusUploady
      key={authCtx.authUser?.userId}
      autoUpload={false}
      multiple={false}
      accept="video/*"
      enhancer={enhancer}
      forgetOnSuccess={true}
      chunkSize={8_000_000}
      parallel={4}
/>

We saw a difference from the package "https://github.com/tus/tus-js-client", which we are using on a different project:

Tus-JS-Client Headers

tus-js-client-parallel-upload

Uploady

tus-uploady-parallel-upload

Expected Behavior The POST requests should have the correct "Upload-Concat" Header ("partial", and "final" for the summarized file).

Versions "@rpldy/mock-sender": "^1.8.0", "@rpldy/retry-hooks": "^1.8.0", "@rpldy/tus-uploady": "^1.8.0", "@rpldy/upload-button": "^1.8.0", "@rpldy/upload-drop-zone": "^1.8.0", "@rpldy/upload-preview": "^1.8.0", "@rpldy/uploady": "^1.8.0",

mariusschroeterCP avatar Apr 03 '24 10:04 mariusschroeterCP

hi @mariusschroeterCP I will look into this and let you know

yoavniran avatar Apr 05 '24 08:04 yoavniran

Hi @mariusschroeterCP Finally found time to have a look. It does indeed seem to be an oversight on my part. Will have an RC version for you to check soon.

yoavniran avatar Apr 20 '24 12:04 yoavniran

fix (finally) released - https://github.com/rpldy/react-uploady/releases/tag/v1.8.1

yoavniran avatar May 16 '24 14:05 yoavniran