flow-coverage-report icon indicating copy to clipboard operation
flow-coverage-report copied to clipboard

add threshold-uncovered option

Open guyfedwards opened this issue 7 years ago • 3 comments

allows threshold to be set by number of uncovered lines instead of percentage of coverage.

In a codebase which continuously grows, if you fix the number of lines uncovered then you (loosely) enforce that all new code should be covered.

closes #168

image

guyfedwards avatar Nov 02 '18 13:11 guyfedwards

wow that's nice! 🎉 Any chance that could be merged?

It is super useful when your app has really good coverage, in my case we have:

  • 98% coverage
  • 20k lines

It means someone can push something with ~200 untyped lines and the coverage won't drop. I could use decimals and get more precise with the required coverage but that PR sounds like a better solution

mpsq avatar Nov 04 '18 17:11 mpsq

@rpl Do you think you can take a look at this? This would be nice to get merged.

dholbach avatar Jun 17 '19 08:06 dholbach

Bump? :sweat_smile:

dholbach avatar Mar 20 '20 10:03 dholbach