Ryan Joseph

Results 23 issues of Ryan Joseph

nice-to-have
code-smells-bad
P3

`_runloop` is really `_tick`: fix this, and improve the implementation in general (to allow both!)

major-feature
code-smells-bad
P3

The `thingspeak` tool seems to hang very occasionally after running fine for long periods (~days), and seems to do so somewhere in the PSubscriber code for listening to redis. That's...

bug
P1

- [ ] Tests - [ ] Coverage for all cmds (sans subscribe?) - [x] #66 - [ ] + ESP-32 - [x] Out of lib files ([`7ca61aa6`](https://github.com/electric-sheep-co/arduino-redis/commit/7ca61aa60768d68858a04f97f38c16f647913bd1)) - [...

It's a mess. (#74 is an example.) `isNilReturn` isn't an ideal interface but at least it gives us an abstraction to hide the mess. This will be even more important...

I recently [formatted the library source](https://github.com/electric-sheep-co/arduino-redis/commit/680e414da1ba4cfcc9fdea97566a27abec1aad34) "by hand" with VS Code to make it consistent, but now that we have a CI pipeline and somewhat of a dev toolchain, we...

The semantics of `RedisCommand::issue_typed()` are bad, specifically that it can return sentinel integers (`INT_MAX - 0x0f` or `INT_MAX - 0xf0`) in the "nil" or error return cases (respectively), meaning that...

invalid

https://github.com/redis/redis-specifications/blob/master/protocol/RESP3.md

Need to add the ability to chose a Redis database number. Simplest implementation would be to just add a [`SELECT`](https://redis.io/commands/select/) command implementation that the consumer must call explicitly. Slightly better...

enhancement
good first issue

Even though `RedisCommand` is currently an internal API, the [immediate-dereference-on-return](https://github.com/electric-sheep-co/arduino-redis/blob/7c1946a5a865bd49929d311e9849fa76331c5db6/Redis.cpp#L25) pattern is terrible and needs be removed. I'm ashamed I wrote it this way in the first place, my bad.

help wanted
code smells
P0