fakerl icon indicating copy to clipboard operation
fakerl copied to clipboard

added deps to app resource file

Open bunnylushington opened this issue 9 years ago • 2 comments

Hi -- I ran into a small issue while building up a release where the fakerl deps were not declared in its app file. (I use fakerl to generate data for automated post-release testing, which is why it's part of the release ... I can imagine wondering.) Anyhow, here's a quick PR with the update. Note that this change is not compatible if projects bundling fakerl declared fakerl's deps in their own app file (relx, at least, complains that duplication applications are included).

Anyhow, thanks again for the library, it's been a godsend!

bunnylushington avatar Jul 31 '15 12:07 bunnylushington

Thanks, @kevinmontuori!

It's generally recommended to use the included_applications feature only when necessary. The use case you describe seems like a good one, but I think you can include the dependencies in the release without declaring them as included_applications. I think the right thing to do here is to add them to the applications. Please see this http://learnyousomeerlang.com/the-count-of-applications#included-applications and https://github.com/erlware/relx/wiki/configuration#priority-application-loading

I'll add them right away.

rpip avatar Aug 05 '15 00:08 rpip

Added the dependencies to the applications.

Please try again and let me know if that solves the problem.

rpip avatar Aug 05 '15 01:08 rpip