dr-scripts icon indicating copy to clipboard operation
dr-scripts copied to clipboard

[script][craft] Updated craft to do T10 and T11 enchanting items. Checks for sigils first as these are hunted and scribed and not store bought.

Open Dartellum opened this issue 2 years ago • 10 comments

Added examples of ;sigilhunter syntax to hunt for the sigils. Also fixed one enchanting recipe that could use any sigil so made it purchase two from Society.

Dartellum avatar Aug 22 '22 22:08 Dartellum

@Dartellum Would like some visual spacing here in the code. It's wall-of-text-ish at the moment.

I'll need @Raykyn55 to help evaluate this as well. I'm not good with crafting scripts.

asechrest avatar Aug 23 '22 01:08 asechrest

Shouldn't be any tools in our hand at this point(re cleanup)

I think the exit is appropriate because we for sure don't want to START crafting without having everything on hand for fear of wasting a sigil we have to farm, but moving it into a separate method for these checks is probably a good idea. Reason being, you have information there that the user might want(the commented information specifically), and if the script just dies, they might know they're missing one of the sigils, but not the whole list. What about sending the needed parts to a method that checks for them, and if any fail, it spits out that helpful set of comments you have in the code?

Something like this in place of the tap checks:

sigils_needed = ['evolution', 'metamorphosis', 'unity']
check_sigils(sigils_needed)

method could be something like:

def check_sigils(sigils)
  missing = []
  missing << sigils.reject { |sigil| DRCI.exists?("#{sigil} sigil-scroll") }
  unless missing.empty?
    DRC.message("Missing #{missing.to_s} sigil-scroll(s). IF you have them, they need to be loose in your bag, if you do not, these cannot be purchased, and must be harvested. We recommend using our sigilhunter script. Run ;sigilhunter help for more information.")
    exit
  end
end

Raykyn55 avatar Aug 23 '22 04:08 Raykyn55

With the new method in DRCC:

>;craft enchanting
--- Lich: craft active.
[craft]>open my embroidered backpack
That is already open.
[craft]>open my party sack
That is already open.
[craft]>open my watery portal
[Assuming you mean a swirling eddy of incandescent light bound by a gold-striated coralite frame.]
You can't do that.
[craft]>open my green backpack
That is already open.
[craft]>open my blue backpack
That is already open.
[craft]>open my red backpack
That is already open.
[craft]>open my duffel bag
That is already open.
[craft]>open my zillinen pouch
That is already open.
[craft]>open my thigh bag
That is already open.
[craft]>open my striking bag
That is already open.
[craft]>open my hip pouch
That is already open.
[craft]>open my champion's belt
That is already open.
[craft]>open my wyvern-hide lootpouch
That is already open.
[craft]>open my canvas sack
What were you referring to?
[craft]>wealth kronars
  9 gold, 5 silver, 46 bronze, and 40 copper Kronars (10,000 copper Kronars).
[craft]>rummage /C sigil-scroll in my embroidered backpack
You rummage through an embroidered backpack depicting a large town by the side of a river looking for something similar to "sigil-scroll":
crafting (7): 
    flawless paradox sigil-scroll comprised of broad strokes (3)
    flawless integration sigil-scroll comprised of broad strokes (2)
    flawless evolution sigil-scroll comprised of broad strokes (2)
[craft]>rummage /C sigil-scroll in my embroidered backpack
You rummage through an embroidered backpack depicting a large town by the side of a river looking for something similar to "sigil-scroll":
crafting (7): 
    flawless paradox sigil-scroll comprised of broad strokes (3)
    flawless integration sigil-scroll comprised of broad strokes (2)
    flawless evolution sigil-scroll comprised of broad strokes (2)
Not enough metamorphosis sigil-scroll(s). You need to harvest 1 more. We recommend using our sigilhunter script. Run ;sigilhunter help for more information.
[craft]>rummage /C sigil-scroll in my embroidered backpack
You rummage through an embroidered backpack depicting a large town by the side of a river looking for something similar to "sigil-scroll":
crafting (7): 
    flawless paradox sigil-scroll comprised of broad strokes (3)
    flawless integration sigil-scroll comprised of broad strokes (2)
    flawless evolution sigil-scroll comprised of broad strokes (2)
Not enough unity sigil-scroll(s). You need to harvest 1 more. We recommend using our sigilhunter script. Run ;sigilhunter help for more information.
--- Lich: craft has exited.

image

Dartellum avatar Aug 23 '22 19:08 Dartellum

Switching to draft so common-crafting PR can get merged first. I will create that one after a few more test runs.

Dartellum avatar Aug 23 '22 22:08 Dartellum

Relies on #6071.

Dartellum avatar Aug 23 '22 22:08 Dartellum

I want to move all the other sections of enchanting to point to the new def.

Dartellum avatar Aug 24 '22 04:08 Dartellum

Added lots of comments. I also incorporated the find training room change from #6082.

Dartellum avatar Aug 25 '22 02:08 Dartellum

:question: Should I change ;craft enchanting to ;craft artificing? Two reasons: first, it would then match ;workorders artificing and second, when invoking and binding are released enchanting will not work.

Dartellum avatar Aug 25 '22 02:08 Dartellum

❓ Should I change ;craft enchanting to ;craft artificing? Two reasons: first, it would then match ;workorders artificing and second, when invoking and binding are released enchanting will not work.

I would argue no, given the nature of this script. The goal here is to train the skill, the script decides the best way to go about it. This is different from workorders, where you're deciding what discipline to do your work in.

Raykyn55 avatar Aug 25 '22 04:08 Raykyn55

question Should I change ;craft enchanting to ;craft artificing? Two reasons: first, it would then match ;workorders artificing and second, when invoking and binding are released enchanting will not work.

I would argue no, given the nature of this script. The goal here is to train the skill, the script decides the best way to go about it. This is different from workorders, where you're deciding what discipline to do your work in.

Okay, fair enough.

Dartellum avatar Aug 25 '22 10:08 Dartellum