dr-scripts icon indicating copy to clipboard operation
dr-scripts copied to clipboard

[script] [combat-trainer] Don't face/engage when using Innocence

Open bishoprook opened this issue 2 years ago • 5 comments

Adds a new is_engaging_allowed? gamestate which is honored by preventing any action that would require a face or engage. This prevents empaths from breaking Innocence (e.g. when manipulating and/or using GS)

bishoprook avatar May 05 '22 21:05 bishoprook

How about treating Innocence like we treat Absolution? Currently the undead argument triggers checks for Absolution, and prevents attacks without the spell cast. It seems consistent to keep that workflow? The it's a more deliberate action on the part of the user, setting the argument in their hunting_info section like we would construct or undead and not just "Oh, is Innocence up?"

MahtraDR avatar May 06 '22 06:05 MahtraDR

The it's a more deliberate action on the part of the user, setting the argument in their hunting_info section like we would construct or undead and not just "Oh, is Innocence up?"

That makes a lot of sense. When I'm defining the hunt I should know that I plan to be using Innocence and I don't want to be dancing to break it.

bishoprook avatar May 06 '22 14:05 bishoprook

Any other thoughts here?

bishoprook avatar May 10 '22 02:05 bishoprook

Any other thoughts here?

If you can clean/resolve any pending comments, and if it's in a place to be re-reviewed, tag us for review?

MahtraDR avatar May 10 '22 03:05 MahtraDR

I'll smoke test this today and if no errors, will merge.

MahtraDR avatar Jul 01 '22 19:07 MahtraDR