dr-scripts icon indicating copy to clipboard operation
dr-scripts copied to clipboard

[script] [hunting-buddy] Add option to pick a room to go to after hunting-buddy ends instead of default safe-room

Open PatricCampbell opened this issue 3 years ago • 5 comments

Does just what the title says, adds a new field force_after_hunt_room to overwrite where hunting-buddy goes when it ends.

Q: Do I need to add something to validator for this to check it's a number?

PatricCampbell avatar Feb 27 '22 15:02 PatricCampbell

👋 Thanks for the submission and following the PR title convention. Great idea to make where characters go after a hunt configurable.

KatoakDR avatar Feb 27 '22 17:02 KatoakDR

Do I need to add something to validator for this to check it's a number?

That would be helpful; assuming there exists validation logic for other room settings then you should be able to copy/paste most of what they do, thanks

KatoakDR avatar Mar 02 '22 19:03 KatoakDR

Hi @PatricCampbell, haven't heard any follow up from you on the code comments. Going to switch this back to draft status. When/if you're ready to continue simply follow up on the open comments. Thanks!

KatoakDR avatar Mar 27 '22 16:03 KatoakDR

Why would you not want to go to your safe room?

Dartellum avatar May 01 '22 00:05 Dartellum

Why would you not want to go to your safe room?

An example would be, I've got 7 different hunts multiple near Boar clan, some near Shard, and a few near Crossing. Running back to shard each time only to head back to either Boar or Crossing is a huge waste of time. Going to a safe room near your last hunt and then checking where it needs to go next just saves time

I think this is a fantastic idea an hope the work gets completed!

Promithius-DR avatar May 02 '22 03:05 Promithius-DR