dr-scripts icon indicating copy to clipboard operation
dr-scripts copied to clipboard

[script] [checkfavors] Prydaen Favors

Open Kaesken opened this issue 3 years ago • 7 comments

Created a script for Prydaens who want to use the Triquetra in the favor_god instead of the Thirteen (or their aspects).

Kaesken avatar Feb 02 '22 04:02 Kaesken

Hah! I figured out the draft! I'll look at this tonight. Thanks so much @rpherbig !! :)

Kaesken avatar Feb 02 '22 14:02 Kaesken

@rpherbig you're an excellent code reviewer. Thanks for taking time to mentor folks through the code review process

KatoakDR avatar Feb 02 '22 15:02 KatoakDR

@KatoakDR I tried to add the new TT lumbering/mining rooms but it posted it in here. How do I get it into it's own separate thing to be merged?

Kaesken avatar Feb 02 '22 16:02 Kaesken

@KatoakDR I tried to add the new TT lumbering/mining rooms but it posted it in here. How do I get it into it's own separate thing to be merged?

How are you currently editing code and tracking changes on your computer? Are you using GitHub Desktop maybe?

asechrest avatar Feb 02 '22 17:02 asechrest

@KatoakDR I tried to add the new TT lumbering/mining rooms but it posted it in here. How do I get it into it's own separate thing to be merged?

How are you currently editing code and tracking changes on your computer? Are you using GitHub Desktop maybe?

Yes, Mahtra showed me to download it. Still learning tho :( I hate to be a bother to anyone.

Kaesken avatar Feb 02 '22 17:02 Kaesken

@KatoakDR I tried to add the new TT lumbering/mining rooms but it posted it in here. How do I get it into it's own separate thing to be merged?

How are you currently editing code and tracking changes on your computer? Are you using GitHub Desktop maybe?

Yes, Mahtra showed me to download it. Still learning tho :( I hate to be a bother to anyone.

It's no bother. We need more folks contributing. On GitHub desktop, when you are ready to make wholly separate changes from something you have been working on, you can create a new branch from within GitHub desktop, name it accordingly to the new changes you will be working on. GitHub desktop may ask if you want to "stash" the changes in the branch that you were working on so you can come back to them.

Once you create your new branch, a button should pop up that says open in visual studio code. That will pop you over to VSC, and now any file you open and edit within VSC will be new changes on the new branch, which stay separate from the previous branch you stashed your changes on. If you want to go back to the other branch where you made separate changes, you simply select that other branch within get hub desktop and it will pop you over to that previous branch, hit the button to open in VSC, then now you are editing that branch.

asechrest avatar Feb 02 '22 17:02 asechrest

@KatoakDR I tried to add the new TT lumbering/mining rooms but it posted it in here. How do I get it into it's own separate thing to be merged?

How are you currently editing code and tracking changes on your computer? Are you using GitHub Desktop maybe?

Yes, Mahtra showed me to download it. Still learning tho :( I hate to be a bother to anyone.

It's no bother. We need more folks contributing. On GitHub desktop, when you are ready to make wholly separate changes from something you have been working on, you can create a new branch from within GitHub desktop, name it accordingly to the new changes you will be working on. GitHub desktop may ask if you want to "stash" the changes in the branch that you were working on so you can come back to them.

Once you create your new branch, a button should pop up that says open in visual studio code. That will pop you over to VSC, and now any file you open and edit within VSC will be new changes on the new branch, which stay separate from the previous branch you stashed your changes on. If you want to go back to the other branch where you made separate changes, you simply select that other branch within get hub desktop and it will pop you over to that previous branch, hit the button to open in VSC, then now you are editing that branch.

Oooh!! There we go, thank you so much! How do I delete the one I accidentally attached to this one?

Kaesken avatar Feb 02 '22 23:02 Kaesken