dr-scripts
dr-scripts copied to clipboard
rpherbig
Related to #5325 - New installs are getting an empty sample folder
Wasn't me but a returning player reported her fresh install got all of the expected scripts and sample folder but the sample folder was empty. @MahtraDR
Sorry for the double post. Did you point them to the repo? She can just download any needed samples from GitHub as a workaround for now.
I just pointed her at discord. All the guild samples are stored there
On Sat, Jan 8, 2022, 2:23 PM MahtraDR @.***> wrote:
Sorry for the double post. Did you point them to the repo? She can just download any needed samples from GitHub as a workaround for now.
— Reply to this email directly, view it on GitHub https://github.com/rpherbig/dr-scripts/issues/5392#issuecomment-1008114930, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEIKB3J7RH5R5HNKHSSPVTUVCFLVANCNFSM5LQYVI6A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
My guess is https://github.com/rpherbig/dr-scripts/blob/master/dependency.lic#L389
It's not a sample folder at all. It's a zero length Sample file.
I'm looking at reworking the current routine. It's mildly obnoxious to deal with nested folders like we have Samples looking like now.
Note this hasn't fallen off the radar, and I have a working proof of concept. I'm a bit stuck until @kato dependency changes go in though, so i can start from a clean dependency. As soon as his PR gets merged, I'll get one submitted for this.
Still happening on a new install with lich 5.6.1