dr-scripts icon indicating copy to clipboard operation
dr-scripts copied to clipboard

[Script] [workorders.lic] Fix bundling when using a cauldron.

Open Dartellum opened this issue 3 years ago • 6 comments

Updating the bundling logic when using a cauldron. A cauldron allows one to put a complete combined herb stack of 75 in it to craft the recipe. I have not updated to add more than a completed stack. I will need to test if more can go in. However, the logic here should catch even that as I am checking for more 10 or more units in the completed stack to bundle. I will remove the commented-out lines, 645 and 646, if I find they are not required.

Testers are welcomed. :smile:

Dartellum avatar Jul 04 '21 20:07 Dartellum

I'm not really sure how to review this PR. Has it been tested?

rpherbig avatar Aug 24 '21 15:08 rpherbig

I'm not really sure how to review this PR. Has it been tested?

A few have used it to test for me. I had the call out in the #alchemy Discord channel. I can ask again if any challenges were found?

Dartellum avatar Aug 24 '21 15:08 Dartellum

You tell me when you're confident it's been tested and I can merge it

rpherbig avatar Aug 24 '21 16:08 rpherbig

Working well for me still. I should follow-up in Discord to make sure it is working as expected for the others. I have not heard it is not, but I have not heard of it is either.

Dartellum avatar Sep 21 '21 17:09 Dartellum

Sounds good, let me know when you feel it's ready.

rpherbig avatar Sep 22 '21 19:09 rpherbig

Hello everyone. Error with the new workorders. Is it something I did or? Thank you!

--- Lich: error: undefined method check_for_existing_sigil?' for DRCC:Module workorders:706:in enchanting_items' workorders:150:in `work_order'

Angel-DR avatar Jan 12 '23 18:01 Angel-DR

Closing as abandoned. Happy to revisit in a fresh/up to date PR.

MahtraDR avatar Jul 21 '24 04:07 MahtraDR