DND-5e-LaTeX-Template icon indicating copy to clipboard operation
DND-5e-LaTeX-Template copied to clipboard

Japanese update

Open jeandeaual opened this issue 3 years ago • 3 comments

Following-up on #304.

This improves on #213.

The translation for \defaultsensesname can be found on page 10 of the free Japanese Basic Rules:

Screenshot_2021-01-24 dnd_dm_br_ver2 pdf

I fixed the translation for \numberperdayeachname according to the Japanese Monster Manual (see the last line): 2021-01-24-0001 (Small)

Also, I found an issue regarding colons in some translations like \meleeorrangedattackname. The translation includes the Japanese colon (:) but the template already adds a standard colon:

colon

Some other translations like \innateatwillname or \numberperdayname use the standard colon instead of the Japanese one: colon2

I think this is related to #212, i.e. colons should be moved from the template to all translation files. Since this concerns other translations I wanted some opinion before including it in this PR.

For reference, here is the example PDF compiled in Japanese.

jeandeaual avatar Jan 26 '21 00:01 jeandeaual

Regarding \renewcommand\tocchapterabbreviationname{Ch.}, chapter is usually written as 第1章 (for chapter 1). Can I use \renewcommand\tocchapterabbreviationname{第|1|章}? For \renewcommand\pageabbreviationname{pg.}, I couldn't find any reference to it in a source book, so I left it as is.

jeandeaual avatar Jan 26 '21 00:01 jeandeaual

If there is not a |1| in the English file, then it is not available. For situations where this is needed, please add a comment to #308.

"pg." is for referencing a page number for a link. We have the basics of an auto referencing system started with DndArea which gives a page number (pg. XX). This would be used there.

I noticed the build still failed. Is your branch based on the 0.8? Either you need to rebase your branch or fork 0.8 and copy over your changes.

BrianCriswell avatar Jan 26 '21 00:01 BrianCriswell

If there is not a |1| in the English file, then it is not available. For situations where this is needed, please add a comment to #308.

"pg." is for referencing a page number for a link. We have the basics of an auto referencing system started with DndArea which gives a page number (pg. XX). This would be used there.

Then I think pg. also needs a |1| in Japanese. I'll add that to #308.

I noticed the build still failed. Is your branch based on the 0.8? Either you need to rebase your branch or fork 0.8 and copy over your changes.

Sorry, my 0.8 branch was out of date. I rebased on the latest version from your repository.

jeandeaual avatar Jan 26 '21 00:01 jeandeaual