ots-share-app
ots-share-app copied to clipboard
feature: support for files to be put on minio/s3
it'd be really cool to have files written and deleted from minio or S3 endpoint - this way the file size limit would be increased - think about it pls
I’ll look into it. At the moment, backend doesn’t know whether the content is from a file or not. And the way i read file is also not efficient. (I read the file as a data url). That’s the reason I kept the file size small. But I think I can support up 10MB since most of the browsers can handle it. Will 10MB is enough for you ?
For what its worth, I would like a 10mb limit.
I just tested it with 20 megs file and it seems to be ok (rebuilt the code and container). My use case requires whole lot of larger files (private ML datasets, minimum 1GB of size) - that's why I'm asking for minio/s3 backend support.
also, I can see you're saving file content to postgres under content:text field - this will make poor postgres explode when there's more traffic coming to it :D
It also works with 40 meg files, but it's slooow (I'm using brave)
@sokoow , at the moment, files and texts both are saved in Database. The main reason I thought to store both in DB not have an additional artifact to backup and max life time is 24 hours. I will plan in the future to move the files to a location in the disk rather than in DB.
@Solaris17 , I will increase the file size limit to 10mb and make another release ASAP.
ok
@sokoow, @Solaris17, I increased the max file size to 10MB. if you are interested, I added E2E tests too. 😆