docker-registry-proxy icon indicating copy to clipboard operation
docker-registry-proxy copied to clipboard

disable IPv6 via environment

Open moonbuggy opened this issue 3 years ago • 3 comments

I was having the same problem as in issue #108, but I'd prefer not to have to create a custom resolver configuration for Nginx. Things are simpler if entrypoint.sh handles things and the container sorts itself out.

This PR implements a check for the env variable and the appending of ipv6=off to the resolver string if appropriate. I've tried to keep it in line with your coding style elsewhere in entrypoint.sh.

There's also an addition to README.md regarding the variable, but I'm not sure what to do about the link I included there.

I was initially looking at the README.md in PR #109, so I linked to the Custom nginx resolvers configuration heading. That PR hasn't been merged yet, but I left the link in under the assumption it will become functional at some future point.

I'm just not sure if that's the best way to go about things..? I'm happy to remove the link and rebase this PR if you'd like.

moonbuggy avatar Mar 22 '22 05:03 moonbuggy

this is good merge

iamkhalidbashir avatar Aug 11 '23 08:08 iamkhalidbashir

+1 on this, IPv6 ain't a fun time within corporate hub and spoke.

perlboy avatar Apr 25 '24 04:04 perlboy