docker-registry-proxy
docker-registry-proxy copied to clipboard
refactor: bash, dockerfile, and CI
Refactored
- Merge ca gen bash script to entry point as function
- Run test every push change in bash script
- Add gha caching and other CI changes that leads to
<58s
for cached CI test - Refactor bash script as per google style guide
This is, in general, excellent. Thanks.
In the PR workflow, I really wanted two rounds of pulls, and two separate logs, because it's actually testing the cache, so I will rework that back in.
Great tips about the cache mode=gha
.
Formatting wise, I will let shellfmt
decide, but thanks for all the short-circuiting removals.
I will merge this into a feature branch first, I've a big round of merges to do.
In the PR workflow, I really wanted two rounds of pulls, and two separate logs, because it's actually testing the cache, so I will rework that back in.
I will merge this into a feature branch first, I've a big round of merges to do.
Okay.
Question: Have you faced long python compiling time in mitmproxy
when creating arm64
image? Because I am! Almost 1100+ seconds.
Yes! building arm64 under qemu is ridiculously slow. On real arm64 hardware it's ok, of course. I gotta move the mitmproxy
build to the base image https://github.com/rpardini/nginx-proxy-connect-stable-alpine/blob/master/Dockerfile where nginx is already built. Then setup CI there to schedule build every night, even if it's super slow qemu on GHA, we'll never get to experience it.
That would allow for fast(er) arm64 builds of this one, since no building would be done at this level.
I think I should separate changes of this branch in multiple PRs