rp-hal icon indicating copy to clipboard operation
rp-hal copied to clipboard

pimoroni display pack 2 example

Open jgmartin opened this issue 3 years ago • 6 comments
trafficstars

adds an example of using the pimoroni display pack 2.0 with embedded_graphics.

jgmartin avatar Jul 23 '22 17:07 jgmartin

Oops - sorry about that. I thought that clippy lint didn't apply to no_std crates? https://github.com/rust-lang/rust-clippy/pull/5086 but it seems it was re-enabled later with https://github.com/rust-lang/rust-clippy/issues/6161

This is no longer a correctness issue, so you could just disable the clippy warning. Or add cortex_m::asm::nop();, as pico_i2c_pio.rs does. Or, of course, the continue you had before, just without the comment regarding the optimizer.

jannic avatar Jul 31 '22 17:07 jannic

@jgmartin, is https://github.com/rp-rs/rp-hal/pull/395/commits/962742c999327a17fbf4f6398d17afd4a9e73f90 fine with you?

jannic avatar Aug 04 '22 14:08 jannic

Perfect ty @jannic

jgmartin avatar Aug 23 '22 21:08 jgmartin

@jgmartin unfortunately, this branch needs an update: embedded_time was replaced by fugit. Do you want to update the example? I can do it as well, if you like. But I don't have a pimoroni display pack to test the result.

jannic avatar Sep 10 '22 17:09 jannic

This example is also compatible with Pimoroni Display Pack (1.0) as well - the pinout for LED, buttons and LCD controller for both is the same. The LCD controller handles the differences between panels so the circle still renders correctly on the smaller screen even if you leave the screen size set to 320x240 (instead of actual screen resolution of 240x135).

9names avatar Sep 11 '22 04:09 9names

@jgmartin unfortunately, this branch needs an update: embedded_time was replaced by fugit. Do you want to update the example? I can do it as well, if you like. But I don't have a pimoroni display pack to test the result.

No problem I will do this and test it.

jgmartin avatar Sep 29 '22 18:09 jgmartin

This PR should be moved to https://github.com/rp-rs/rp-hal-boards. I am closing it here but be assured these changes would be welcome over there :) .

ithinuel avatar May 13 '23 03:05 ithinuel