get_markets_with_sp

Open jsphon opened this issue 6 years ago • 1 comments

Hello,

The function get_markets_with_sp, returns values which are missing market type ids. e.g.



[OrderedDict([('MarketTypeIds', OrderedDict([('MarketTypeId', [1])])),
              ('eventId', 190538)]),
 {'eventId': '190539', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '1048932', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '422497', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '4175018', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '1190579', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '5142984', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '5086725', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '5143134', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '5143088', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '5143003', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '5178822', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '3981057', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '3978116', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '3929084', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '3978114', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '4454456', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '3978115', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '3919304', 'MarketTypeIds': {'MarketTypeId': []}},
 {'eventId': '4692325', 'MarketTypeIds': {'MarketTypeId': []}}]

If I debug the code, the actual response does contain market ids for all events:

b'<?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><GetSPEnabledMarketsInformationResponse xmlns="http://www.GlobalBettingExchange.com/ExternalAPI/"><GetSPEnabledMarketsInformationResult><ReturnStatus Code="0" Description="Success" CallId="450215a4-65bb-4ce7-b7af-9fa937bf4dd6" /><Timestamp>2019-04-01T11:17:14.3366777+00:00</Timestamp><SPEnabledEvent eventId="190538"><MarketTypeIds><MarketTypeId>1</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="190539"><MarketTypeIds><MarketTypeId>1</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="1048932"><MarketTypeIds><MarketTypeId>1</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="422497"><MarketTypeIds><MarketTypeId>1</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="4175018"><MarketTypeIds><MarketTypeId>1</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="1190579"><MarketTypeIds><MarketTypeId>1</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="5142984"><MarketTypeIds><MarketTypeId>3</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="5086725"><MarketTypeIds><MarketTypeId>3</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="5143134"><MarketTypeIds><MarketTypeId>3</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="5143088"><MarketTypeIds><MarketTypeId>3</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="5143003"><MarketTypeIds><MarketTypeId>3</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="5178822"><MarketTypeIds><MarketTypeId>3</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="3981057"><MarketTypeIds><MarketTypeId>3</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="3978116"><MarketTypeIds><MarketTypeId>14</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="3929084"><MarketTypeIds><MarketTypeId>14</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="3978114"><MarketTypeIds><MarketTypeId>14</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="4454456"><MarketTypeIds><MarketTypeId>14</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="3978115"><MarketTypeIds><MarketTypeId>14</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="3919304"><MarketTypeIds><MarketTypeId>14</MarketTypeId></MarketTypeIds></SPEnabledEvent><SPEnabledEvent eventId="4692325"><MarketTypeIds><MarketTypeId>16</MarketTypeId></MarketTypeIds></SPEnabledEvent></GetSPEnabledMarketsInformationResult></GetSPEnabledMarketsInformationResponse></soap:Body></soap:Envelope>'

I have a feeling the problem might be due to the WSDL, rather than the code in this Github repo. But I am not sure. I'm therefore not sure how to produce a clean fix for this.

I will shortly push a hacky solution in my fork. I'm aware that the solution is not at all in line with the design-goals of this package, and apologise in advance.

Apr 01 '19 11:04 jsphon

A non-elegant fix:

https://github.com/jsphon/betdaq/commit/1d28beab50fe468e6439fb38851e7e30cc886986

Apr 01 '19 11:04 jsphon