Rozhkov Dmitrii
Rozhkov Dmitrii
Just to notice: The workaround is to install with `cargo` ```sh cargo install wasm-pack ``` It will be placed in `~/.cargo/bin`, this path will have to be added to `PATH`
> why not use the same dependency versions used in mm2 when you can to make it easier for dep reviewers [done](https://github.com/KomodoPlatform/komodo-defi-framework/pull/1932/commits/6cd77d2e22698eea088d859d8212683c0297d614) + [description](https://github.com/KomodoPlatform/komodo-defi-framework/pull/1932#issue-1836102182) cc: @shamardy
> 2. I see you changed some lifetime optimized structs/funcs to not using lifetime and you opted in for cloning the data instead... can you share a reason why you...
> mm2src/mm2_rpc/src/structs/ is a more appropriate mod name compare to mm2src/mm2_rpc/src/data/. Data is more commonly used for network layer data types, it could be structs, enums, aliases ... anything that...
> Thank you for the fixes! Next review iteration, I finished reviewing all changes related to mm2 code. Will have a quick look at adex-cli in next review. One note,...
@smk762, @kivqa, hello! Let me inform you that [komodefi-cli reference](https://github.com/KomodoPlatform/komodo-defi-framework/blob/1799-swap-commands/mm2src/adex_cli/src/doc/CLI_REFERENCE.md) has been completed and ready to review
#### Testing `enable_erc20` ##### enabling platform coin ```sh $ release/komodefi-cli enable ETH Enabling coin: ETH coin: ETH address: 0x224050fb7EB13Fa0D342F5b245f1237bAB531650 balance: 0.043332961727987327 unspendable_balance: 0 required_confirmations: 3 requires_notarization: No ``` ##### `activation_scheme.json`...
#### Testing `enable_eth_with_tokens` ```sh $ release/komodefi-cli enable ETH Enabling coin: ETH current_block: 17783997 eth_addresses_infos: │ address, pubkey │ method │ balance(sp,unsp) │ tickers │ │ 0x224050fb7EB13Fa0D342F5b245f1237bAB531650 │ Iguana │ 0.04:0...