Roman Rozenshteyn

Results 8 comments of Roman Rozenshteyn

I was considering working on this issue. So, I took a look at the code of the [MethodScanner](https://github.com/cucumber/cucumber-jvm/blob/acd2482494eb32f340fcd10b3589cdf1d663013f/java/src/main/java/io/cucumber/java/MethodScanner.java) mentioned above and it only requires the test class to be public...

Oops. You're right. I will test out what happens if getDeclaredMethods() is used instead of getMethods().

I've made progress in implementing a solution for this request. I do have a question about some functionality though. There is a test in MethodScannerTest and JavaBackendTest that tests the...

In the implementation that I'm trying to test I'm using [Class.getDeclaredMethods()](https://docs.oracle.com/javase/8/docs/api/java/lang/Class.html#getDeclaredMethods--) which: ``` public Method[] getDeclaredMethods() throws SecurityException Returns an array containing Method objects reflecting all the declared methods of...

May I take a crack at this? If yes, I have a couple of questions: 1. Does the proposed new property dropIfExists need to be exposed as the attribute of...

Thank you for the clarifications @nvoxland ! I have made initial code changes already. Will try to update them based on the feedback and, hopefully, submit them this coming weekend.

I've coded a change to address this issue, but I'm having problems with the unit test for this change. Specifically, how to set the value of the new property (that...

I was able to test by setting a System.property: System.setProperty("liquibase.dropIfCannotReplace", dropIfCannotReplacePropValue) However, I'm still not sure how to integration test that setting the property in the liquibase.properties file will work....