Michael Rosenberg comments

Results 157 comments of


                                            Michael Rosenberg

New major versions

Sounds good

curve!: use constant-time compressed Ristretto equality testing

Yeah that's unfortunate. I really doubt anyone has ever used a `CompressedRistrettoPoint` in a match statement, especially since this is a [relatively new](https://github.com/rust-lang/rust/issues/120362) feature. But semver is semver. Tbh I'm...

ed25519-dalek: bring signature identifiers

Also approved. Just wanna rerun the tests somehow

Don't implicitly enable zeroize for ed25519-dalek alloc feature

Thank you! @tarcieri is this technically breaking? It could make existing code cease to zeroize structs

Don't implicitly enable zeroize for ed25519-dalek alloc feature

Ok agreed. I labeled this so we can come back to it next major release

Support NIST validation criteria for Edwards points

I like the latter style. Maybe called `EdwardsPoint::validated_decompress`. I thought about maybe supporting arbitrary validation routines by defining a trait. But for now I think it suffices to have a...

Can PublicKey/PrivateKey be exposed?

You're not the first person to mention this issue. This seems possibly doable, but frankly I don't have a ton of time to work on usability fixes for this crate....

[Feature] All-or-nothing multi-put operation for R2 bucket

A kind of nasty workaround is to have a third key C. This key contains "flip" or "flop". Rather than storing "A" and "B", the program stores "A_flip" and "B_flip",...

curve!: use constant-time compressed Edwards equality testing

Thank you for these!

Update x25519-dalek requirement from 1.1 to 2.0

Can I archive this repo? Neither I nor ToB are maintaining it now