roystgnr

Results 312 comments of roystgnr

I'll review if @GiudGiud doesn't mind.

Let me kick those failing tests; looks to me like they just happened to coincide with some planned github.inl.gov downtime.

Happy with the changes for the issues I caught.

Is this being run in parallel? You don't say anything about that in "Steps to Reproduce", but I'd be very surprised to see a ghosting error triggered by a serial...

If you never actually use your variable, then it takes a non-discontinuous non-`isNodal()` variable to hit an error with this stack trace. (I can never remember which variables satisfy `isNodal()`,...

#13417 is related in the sense that it has the same "is it elemental or is it nodal" false dichotomy. Most finite elements are not elemental (because their support spans...

I need to edit my rants better, or maybe only post the conclusions rather than the full stream-of-consciousness. I did get to that same "thereby gets garbage" conclusion eventually.

> Maybe we can have a function to return how many dofs associated with an object This is `dof_object->n_comp(sys_num, var_num)`. > and a function to return which object a dof...

> number of variables you have in one variable group is not the number of dofs you have in one variable. Thousands of components in an array variable would mean...

> Not sure what you mean the reverse lookup The normal lookup here is the function which returns which dofs are associated with an object; hence > a function to...