roystgnr

Results 312 comments of roystgnr

I'm just going to kick that Valgrind recipe. Only one memory error, and it happens to be triggered by WebServerControl at a time when we've been having network issues? That's...

Not sure about the MOOSE interface here, but at least as a first step I'll see about adding libMesh (and lower) level APIs to expose the sets of options that...

> Potentially allow making the RHS vector in ExplicitSystem ghosted This is allowed as of https://github.com/libMesh/libmesh/pull/3630 - `sys.add_vector("RHS Vector", false, GHOSTED)` will now change `sys.rhs->type()` to `GHOSTED`.

On the other hand, especially after the discussion this morning, I'm not sure exactly how "which would allow us to not create our ghosted non-time vector for use cases like...

> ParMETIS is our current default partitioner in parallel runs Are you calling Parmetis via a `PetscExternalPartitioner`? If so then I'd not call that a "default"; it's something that has...

IIRC several years ago we put basic remapping into libMesh::System I/O: variable data would be read into variables of the same name regardless of whether the variable ordering/numbering had changed,...

Closing this in favor of a much bigger branch with diagnostics and fixes for the bugs I uncovered.

> I thought instead of just hard-coding the various properties (e.g. the no. of dofs) we could try to generalise them. This is usually a good idea and a pretty...

Sorry for the late review; this all looks like obvious improvements to me (assuming the higher-`o` cases are correct; I can't wait until we have that working!). I'm going to...

> If you are happy with https://github.com/libMesh/libmesh/commit/0f0ca51fcdf7e695c0c13c3a2f2a3ef4884c662c I'm fine with it, but I actually wouldn't have gone in that direction myself. > are there any FE families (or any other...