eslint-friendly-formatter icon indicating copy to clipboard operation
eslint-friendly-formatter copied to clipboard

Using solarized light theme in intellij the white rule name is not visible light tan background

Open tirams opened this issue 9 years ago • 3 comments

Can you either change the rule color to something that works on light or dark like chalk.green or add an env var to configure the rule color to use.

i.e. light with white whitebackgrd dark with white darkwithwhite

vs.
light with green lightwithgreen

dark with green darkwithgreen

tirams avatar Oct 26 '15 17:10 tirams

I wouldn't address this issue using environment variables, Instead, I suggest the api should support receiving color mapping for the various outputs.

@royriojas What do you think?

eladchen avatar Oct 05 '16 10:10 eladchen

@eladchen, sure it can be also a parameter, the problem is that since this tool is executed from eslint, the flags to the reporter need to be passed doing something like:

eslint -f node_modules/eslint-friendly-formatter client/**/*.js server/**/*.js -- --eff-theme="solarized" #notice the -- before the reporter flags

but I'm definitively open to PRs for this feature.

royriojas avatar Oct 05 '16 18:10 royriojas

There is already this option in the meantime, hope it help

lionel-bijaoui avatar Jan 09 '19 13:01 lionel-bijaoui