node-epimetheus icon indicating copy to clipboard operation
node-epimetheus copied to clipboard

http_* metrics

Open errordeveloper opened this issue 8 years ago • 3 comments

It seems like the metrics exposed right now do not adhere to best-practice. I'd like to discuss this before proposing any changes :)

errordeveloper avatar Jun 15 '17 12:06 errordeveloper

Ok, just reviewed my findings from earlier on, and I think the only odd thing is the unit of time – some of my colleagues insist that _seconds should be used instead of _miliseconds, but I don't think there is an agreement on this in the wider community... Let's discuss, may be we could make the unit configurable?

errordeveloper avatar Jun 15 '17 13:06 errordeveloper

@tcolgate @Olical renamed this to *_seconds in their fork.

errordeveloper avatar Jun 16 '17 08:06 errordeveloper

Happy to take a pull request on this. Please follow these guidelines if you do

roylines avatar Aug 21 '18 16:08 roylines