react-flexbox-grid icon indicating copy to clipboard operation
react-flexbox-grid copied to clipboard

Hidden columns

Open Falieson opened this issue 8 years ago • 6 comments
trafficstars

  • [x] updated docs
  • [x] updated tests
  • [x] updated Col.js component with hiddenMap var and if/else instead of ternary
  • package.json => replaced flexboxgrid with this PR which adds hidden classes https://github.com/kristoferjoseph/flexboxgrid/pull/211

resolved issues

  • https://github.com/roylee0704/react-flexbox-grid/issues/57
  • https://github.com/roylee0704/react-flexbox-grid/issues/13

Falieson avatar Dec 27 '16 19:12 Falieson

@silvenon there's finally been some movement on that flexboxgrid PR. The author of FBG wants to keep the package size small, and if people want the extra features use https://github.com/lgg/flexboxgrid-helpers

I will resubmit this PR with the extra pkg dependency, or if you prefer - I can maintain a fork of FBG with extended features https://github.com/kristoferjoseph/flexboxgrid/pull/211#issuecomment-298641394

Falieson avatar May 02 '17 14:05 Falieson

@Falieson any news on this?

cyberhck avatar Aug 02 '17 02:08 cyberhck

+1

mattotodd avatar Aug 04 '17 19:08 mattotodd

Sorry - I'm swamped with my new job. This react-flexbox-grid package should be updated to use https://github.com/evgenyrodionov/flexboxgrid2 , I am very glad that @evgenyrodionov (author of redux-logger) stepped up to maintain the package as I'm obviously not the best choice to be the new maintainer. I think that @evgenyrodionov will adopt hidden-columns as part of the new flexboxgrid2 package rather than requiring a helper package. Whether or not this branch includes the package change is up to you, but this PR still has to be done on the new package: kristoferjoseph/flexboxgrid#211

Falieson avatar Aug 08 '17 17:08 Falieson

Anyone taking over this PR?

benoj avatar Aug 22 '17 14:08 benoj

Should this one be marked as closed in favour of https://github.com/roylee0704/react-flexbox-grid/pull/138?

anton6 avatar Apr 07 '18 23:04 anton6