react-flexbox-grid icon indicating copy to clipboard operation
react-flexbox-grid copied to clipboard

Published 20 hours ago • verified publisher icon roylee0704

Not compatible with with flexboxgrid2@>=7.0.0-alpha12

Open houkanshan opened this issue 7 years ago • 14 comments

Hi, recently I upgraded react-flexbox-grid, but found that all the padding of <Col> missing.

[email protected] began to use [class^="col-"] selector instead of using class name explicitly. Which I believe will be dropped by css-loader's CSS Modules when we @import styles from 'flexboxgrid2/flexboxgrid2.css';

If we install react-flexbox-grid with yarn then everything will be fine because flexboxgrid2's version is locked to 7.00-alpha7 by yarn.lock. But if we install it with npm, then [email protected] will be selected according to ^7.0.0-alpha7 in package.json.

So currently can we just lock flexboxgrid2's version to 7.0.0-alpha7 in package.json?

Thank you!

houkanshan avatar Feb 02 '18 08:02 houkanshan

+1 for this issue. We lose all shared column styling and are only left with the column width class. Makes for a very sad looking grid.

hilarykitz avatar Feb 09 '18 15:02 hilarykitz

My repo at https://github.com/jacargentina/flexboxgrid2 fixes this. @roylee0704 could u update to use my fork?

jacargentina avatar Feb 27 '18 20:02 jacargentina

@jacargentina if we will switch forks just for minor bugs, we will never use stable software.

imevro avatar Feb 27 '18 20:02 imevro

@houkanshan can you reproduce problem with css loader on codesandbox.io? Because it is absolutely valid css and if this bug is really with loader, we need file an issue to them.

imevro avatar Feb 27 '18 20:02 imevro

Fixed in 7.2.0

imevro avatar Feb 28 '18 15:02 imevro

@evgenyrodionov Who is in charge for new versions here? Getting that new dependency 7.2.0 would be nice!!

jacargentina avatar Mar 06 '18 17:03 jacargentina

@jacargentina @roylee0704 I guess

imevro avatar Mar 07 '18 14:03 imevro

@roylee0704 Please, publish a new version, having flexboxgrid2 updated to 7.2.0

jacargentina avatar Mar 14 '18 22:03 jacargentina

@silvenon @heldr I've tried contacting @roylee0704 to its gmail, but not having response. Somebody is actively looking at the project? it is discontinued ?

jacargentina avatar Apr 03 '18 18:04 jacargentina

I merged the PR, but unfortunately I don't have permissions to publish the new version of react-flexbox-grid. 😢

silvenon avatar Apr 05 '18 17:04 silvenon

Me neither 😢

heldr avatar Apr 05 '18 18:04 heldr

@silvenon @heldr any way to contact @roylee0704 ? Is he alive?

jacargentina avatar Apr 05 '18 18:04 jacargentina

I'm sure he's alive 😄 he just doesn't seem to have a strong online presence or has other things to do. I reached out to him and will let you know if he replies. (Déjà vu. #99)

silvenon avatar Apr 05 '18 21:04 silvenon

@houkanshan and everybody following. I've put this https://jacargentina.github.io/react-flexbox-grid/ It is full of updates! Cheers.

jacargentina avatar Apr 19 '18 16:04 jacargentina