Roy Dahan
Roy Dahan
I created a separate issue for the above comment in qa-tasks.
> My eyes hurt from seeing so many `elif'. See > > https://github.com/scylladb/scylla-machine-image/blob/ad01b2a28092b0488f5de443da51a51285c98a14/common/scylla_cloud_io_setup#L41 > > > We should store this in a dictionary, JSON or whatnot. Single location preferably. Hurt...
For now we cannot allow this change as we're facing a recent regression in this tests results. Hence, it's a bad practice to change this test until the investigation is...
@Mark-Gurevich I suggest stop extending this PR so it won't be too big so we can merge it.
Please take out from draft when it's ready for review
Same as the other one. We won't change the test while there is an ongoing investigation for regression.
@vladzcloudius already approved that the results on master can be treated as the expected results. I don't think we should wait more with this.
This PR is just getting rotten here. @ShlomiBalalis is not available. We need someone to finalize the work. If we don't do it, I'm going to merge it and we...
reminder to self: I ran https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/Shlomo/job/2023.1-artifacts-ami-arm-test/4/ and all tests passed. Need to go over the log and make sure it did what we expected it to do.
@ShlomiBalalis please try to get back to it, so we will merge it.