rox

This repo is now deprecated, since ncm is deprecated by ncm2 http://github.com/ncm2/ncm2 It should have been fixed in https://github.com/ncm2/ncm2-github

I've pushed an update If it's still not working. I'll need the log files. `:help NCM-trouble-shooting`

@dantleech It make sense to me. `phpactor#get_working_dir` should auto detect project root by default , since IMO it works for most composer based php projects.

> I think there are too many edge cases when detecting the root (and the magic behavior can just be confusing). In what case? phpactor is always depending on vendor/autoload.php...

> If there is no composer, we traverse to the root of the FS, which is weird, a refactoring tool that does dangerous things shouldn't be in the root of...

hmm I'm more concerned about the security issue mentioned by @dantleech If there's no better solution. I will merge #2 instead, for security and consistency

> If there is no composer, we traverse to the root of the FS, which is weird, a refactoring tool that does dangerous things shouldn't be in the root of...

https://github.com/roxma/ncm-phpactor/issues/1#issuecomment-326551345 If this PR get merged, the user change directory to another project with nvim's `:cd dir`, phpactor won't work?

The `cd` command inside `UpdatePHPActorPath` doesn't look good to me. If `cd` is executed automatically, plugins like FZF, ag will be affected. I would rather automatically use the directory of...

OK My point is, it doesn't look like a good idea to accept `g:phpactorInitialCwd` as `phpactor/plugin` does Perhaps @dantleech could give some advice // https://github.com/phpactor/phpactor/commit/65b97935c567d4141a81ed7a9b9bb6bd8bbb8af4#diff-b96c23eeb9efb3d1ce52e97eaf5019b6R11