spank icon indicating copy to clipboard operation
spank copied to clipboard

A page without URLs displays an infinite spinner

Open Ertego opened this issue 2 years ago • 1 comments

If spank has no urls (empty array in urlIndex.json), it just displays an infinite spinner without an error message. I think it might be better to display an error message in this case.

Ertego avatar Jul 13 '21 10:07 Ertego

Sorry about the slow reply @Ertego .

I much agree. I'll add it to our todo list... unless you're interested in submitting a PR. 😇

const assert from 'assert'

const getConfig = async input => {    
    const options = configent(defaults, input, {useDetectDefaults: true, module})
    /** run assertions */
    return options
}

https://github.com/roxiness/spank/blob/master/getConfig.js

jakobrosenberg avatar Jul 18 '21 07:07 jakobrosenberg