routify icon indicating copy to clipboard operation
routify copied to clipboard

isChangingPage Is Set "Too Late"

Open Rican7 opened this issue 2 years ago • 6 comments

Description

While trying to use the $isChangingPage helper, I noticed that it fires "too late". It won't set to true until after the page is already navigated to, which makes it relatively useless. 😞

I believe the issue here is that the value isn't set to true until after the route's components have been preloaded...

Would it not make sense to just move the stores.isChangingPage.set(true) bit to before the route.api.preload() call? Or, could it not be maybe moved to be set as a hook in the $beforeUrlChange helper, similar to how its currently set to off in $afterPageLoad?

Package Versions

$ npm ls --depth=0 @roxi/routify svelte
[email protected] REDACTED
├── @roxi/[email protected]
└── [email protected]

Rican7 avatar Jan 02 '22 08:01 Rican7