helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[pgadmin4] namespace name need to quote to support numeric named namespace

Open miteshpatelfxt opened this issue 1 year ago • 0 comments

Describe the bug A clear and concise description of what the bug is.

Version of Helm and Kubernetes:

Which chart: pgadmin4

What happened: we use numeric namespace name getting this error.

json: cannot unmarshal number into Go struct field ObjectMeta.metadata.namespace of type string.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know: Thank you. I tested it locally, just need to add "| quote" in the pgadmin.namespaceName helper function

{{/* Create the name of the namespace */}} {{- define "pgadmin.namespaceName" -}} {{- default .Release.Namespace .Values.namespace | quote }} {{- end }}

miteshpatelfxt avatar Feb 01 '24 18:02 miteshpatelfxt