gitx icon indicating copy to clipboard operation
gitx copied to clipboard

Tip of currently selected branch rendered outside of history view

Open cbrunnkvist opened this issue 10 years ago • 7 comments

Whenever I select a branch, local or remote, the history view scrolls to one-commit-below the most recent commit. The effect is that I cant see it but have to scroll the history view up. It makes navigating and identifying branches kind of hopeless.

N.b. This issue only manifests itself when the history pane is showing "All branches".

Expected

skarmavbild 2014-12-03 kl 14 28 05

Actual

skarmavbild 2014-12-03 kl 14 27 56

cbrunnkvist avatar Dec 03 '14 07:12 cbrunnkvist

This bug is only present in the rowanj fork of GitX AFAICT.

cbrunnkvist avatar Dec 03 '14 07:12 cbrunnkvist

This is fixed by my change in #399.

ghost avatar Dec 04 '14 01:12 ghost

Sweet. I suspected that ticket and mine were perhaps talking about the same, or similar problem, but with different wording. Prior to posting this I downloaded your fork and tried to build it but build.py failed at objective-git whatever that library is called. I didn't spend any time trying to fix it though. :)

Do you have a finished build somewhere?

cbrunnkvist avatar Dec 04 '14 01:12 cbrunnkvist

You most likely forgot the bootstrap step. It should build cleanly if you follow the instructions in the Development section of the readme.

ghost avatar Dec 05 '14 00:12 ghost

Correct, I missed one step of the bootstrap section.

Indeed, #399 corrects the bug!

cbrunnkvist avatar Dec 11 '14 04:12 cbrunnkvist

This issue also affects tags, i.e. when I select a tag the history entry for the selected tag is always one above the history entry that is displayed at the top of the list.

Kind of annoying when you try to review releases (by clicking on their tags) and always have to scroll up after selecting a tag. Can anyone confirm that #399 also fixes this?

mpfeiffermway avatar Dec 12 '14 14:12 mpfeiffermway

@mpfeiffermway affirmative: the adjustScroll method works the same for both cases, and in addition I just tested it and yes it brings tags into view properly as well. :+1:

cbrunnkvist avatar Dec 13 '14 04:12 cbrunnkvist