rowanj
Please add the ability to copy from the diff window
Apart from missing line-wrap #155 it would be great if I could copy from the diff window.
At the moment not only I can't select text (it highlights the whole line), but it's impossible to copy either.
I agree copying from the diff window would be great, but only as long as the functionality to stage individual lines or line ranges is kept.
Pull Request #191 is my proposal to this problem: a button at the top right of the diff view next to the context slider to toggle between the selection modes stage and copy. What do you think?
Stage mode
Copy mode
Actually I need to copy when looking at older commits. To re-apply some code or stuff like that.
Regarding staging, I don't see why it can't allow both copying and staging at the same time. But anyway, I am worrying about copying code from commit diffs.
Nick
On 9 Jun 2013, at 19:47, Alexis Hildebrandt [email protected] wrote:
Pull Request #191 is my proposal to this problem: a button at the top of the diff view to toggle between the selection modes stage and copy.
— Reply to this email directly or view it on GitHub.
@firedev Copying from older commits already works for me (see screenshot below). Please describe in more detail what you would like to do in order to "copy from the diff window".
You can't copy from Stage window where you mark lines for commit.
Sorry for my confusing messages prior, I was sending it form my phone without actually taking a look.
Nick
On Thursday, 13 June 2013 at 19:37, Alexis Hildebrandt wrote:
@firedev (https://github.com/firedev) Copying from older commits already works for me (see screenshot below). Please describe in more detail what you would like to do in order to "copy from the diff window".
— Reply to this email directly or view it on GitHub (https://github.com/rowanj/gitx/issues/161#issuecomment-19388763).
Also when you copy anywhere, multi-line copying doesn't really seem to be possible.
I'm not sure a Stage-Select toggle is the best way to go, because I expect selection and copy-paste to always work, and hiding it behind a toggle seems counter-intuitive IMHO. Maybe it's possible to detect in which direction the selection is started and choose Stage or Select depending on that (selection moving left-right => Select, selection moving top-bottom => Stage) ?
Another option would be to use the line numbers to toggle per-line staging. That way the regular cursor selection could be used solely for copying.
I don't think the interface for copying needs to be a mode; copying a selection should Just Work. I know the HTML/JS interface is terrible for controlling that, but I think adding modes is going to compound the issue more than solve it.
I agree, that modes would make it a lot more complicated than necessary. Selecting text is already possible, so the solution can't be that far. For a first step being able to copy linewise, would already be great.
