Alex Rousskov

Results 212 comments of Alex Rousskov

> Francesco: It looks to me like you found a genuine issue. I would like to second Francesco's opinion: @jtstrs, your research/PR is very valuable, even if there are usually...

> I'll prefer to stick an approach with encapsulation of construction/deleting `ai_addr` OK, we will wait for your changes before polishing this up. No rush!

> now I supposed to push my efforts to getting rid of a dynamic allocations for all usages of `addrinfo` related to `recv` and `getsockname` syscalls in scope of current...

> > Find one addrinfo use case where addrinfo object is dynamically allocated, its length argument is supplied to some system call like recvfrom() to be updated, but the object...

> Probably we could use `sockaddr_storage` type inside of Ip::Address class ... and also wrap all system api calls inside of separate module ... What do you think? Ip::Address does...

> We can wait for the full refactor requested. Your call. I have not requested refactoring, but I agree that Squid is missing a lot of logic in this "Who...

@yadij, this old PR is meant to fix several CodeQL failures that became "official" after #693 landed (commit 4cf4730). The PR branch has not seen any changes for almost a...

> I'm not sure what the M-failed-description tag means, presumably some sort of formatting issue? Yes, probably. Please see [Anubis](https://github.com/measurement-factory/anubis/blob/master/README.md#pull-request-labels) docs about pull request labels (linked from each Anubis label...

> Andrey: I have adjusted the description. Thank you very much! Assuming your commit [8c0b194](https://github.com/squid-cache/squid/pull/1597/commits/8c0b1940820b037216d1c049d17de843fd4797b9) fixes CI tests, the ball is now fully on the Squid Project side. > >...