persid icon indicating copy to clipboard operation
persid copied to clipboard

Resolve compiler errors and linter warnings

Open pjones opened this issue 1 year ago • 1 comments

Allow this package to be byte compiled by resolving compiler errors. Also addresses all warnings from package-lint.

pjones avatar Aug 19 '24 20:08 pjones

I still do have one error after this patch:

In end of data:
persid.el:530:35: Warning: the function ‘json-parse-buffer’ is not known to be defined.

nicolas-graves avatar Sep 26 '24 12:09 nicolas-graves

Back to work, sorry for long long delay. There are now some conflicts, could you possibly rebase ? Else I can probably manually resolve conflicts.

rougier avatar Jan 06 '25 12:01 rougier

I will rebase (hopefully) some time this week.

pjones avatar Jan 06 '25 15:01 pjones

I rebased this PR.

Note: package-lint-current-buffer still reports the following issues but I didn't want to make larger changes than I already have.

5 issues found:

142:1: warning: `eval-after-load' is for use in configurations, and should rarely be used in packages.
510:0: error: `persid--openalex/normalize-name' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
518:0: error: `persid--openalex/venue' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
535:0: error: `persid--pmc/pmid-to-doi' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).
549:0: error: `persid--pmc/pmcid-to-doi' contains a non-standard separator `/', use hyphens instead (see Elisp Coding Conventions).

pjones avatar Jan 08 '25 10:01 pjones