Newly created frames inherit styles from previously loaded nano-theme even after it is disabled

[jamescherti]

I noticed that if I load one of the nano-theme themes using load-theme, then subsequently disable all themes and load a different (non-nano) theme, and then execute make-frame, the newly created frame still appears to be affected by the previously loaded nano-theme, even though it is no longer active.

Here is an example: the blue theme (tomorrow-night-deepblue-theme) is the one loaded after disabling the nano-theme. However, when I executed make-frame, the newly created frame inherited some colors from the previously loaded nano-theme, despite it no longer being active:

The same issue occurs with other themes as well. For example, with ef-melissa-light, the new frame inherits colors from the previously loaded theme, even though it is no longer active.

[rougier]

Thanks for the report. I guess it is not the case with other team, is it?

[jamescherti]

The issue occurs exclusively with nano-theme. I have tested other themes, including doom-themes, modus-themes, tomorrow-night-deepblue-theme, and ef-themes, and have never encountered this problem with any of them.

[rougier]

I think it's a problem with inheritance and the way I coded thing. Every face inherits from the 6 basic nano faces and if a new theme does not discard inheritance, it may be still active. Not sure how to solve yet unless discarding inheritance for all faces before loading a new theme.