rougier
`(nano-light)`/`(nano-dark)` not working from init file
Hi, I've been trying out this version of nano-theme (as opposed to the one in the nano-emacs repo) and trying to get it to work with the recent rewrite of nano-modeline. However, it seems that even though I have (nano-dark) called in the init file right after (require 'nano-theme) and before (require 'nano-modeline), the theme itself isn't applied before the modeline is initialized, which leads to "unspecified-bg" errors being thrown and a weird-looking modeline.
When using (nano-dark) in the init file and opening a new emacs window, I get this:
where the light theme is used by default and I have to call
M-x nano-dark for things look as expected. Once I call it, every subsequent frame looks fine.
When I use (nano-dark), run emacs in daemon mode and open a new client, the same issue occurs.
When using (nano-light) and opening a new emacs window, interestingly it looks perfect out of the box.
When I use (nano-light), run emacs in daemon mode and open a new client, however, I get this:
where some colours are not defined as expected. Once again,
M-x nano-light seems to fix things except for reloading the modeline, which continues to show some pre-nano-light colours.
Either way, the border for the modeline remains until the M-x theme command is called.
I tried looking a little deeper and noticed some oddities that I'm not sure are the actual issue, but might still be worth noting.
Here,
nano-modeline-face-buffer-read-only gets its foreground from the background of default, which does indeed have a defined background, having defined it in nano-theme-support.el. However, quite often (I'm not able to replicate it consistently) a lot of faces (all in the modeline) tend to get unspecified-bg as a parameter like this.
Apologies for the extremely long post, and please do let me know if I've missed out on providing some information that might help. Thanks so much for the amazing packages!
Thank you for the detailed report. I also noticed the problem with rewrite branch and the wrong colors when switching from light to dark. I'll try to fix it before merging the rewirte branch of modeline. By the way, does it happen with the main branch?
I would have guessed that the main branch would have been perfectly fine, but it turns out that even that breaks.
Below is what I get when I start a daemon and then a client frame with (nano-light) (main branch of modeline):
I've noticed that nano-dark also only runs into issues when started as a daemon. I'm no longer able to replicate any issue when running emacs with either theme (and either branch).
My guess would be that the theme doesn't load when daemonized but the modeline loads anyways which leads to the unspecified-bg warnings, but I haven't been able to verify this or work around it.