minibuffer-header icon indicating copy to clipboard operation
minibuffer-header copied to clipboard

header exceed window-width

Open jcs090218 opened this issue 3 years ago • 8 comments
trafficstars

Thank you for this awesome package!

I think there is a miscalculation (window-width) going on with this package? 😕 Below is a screenshot.

Image 1

jcs090218 avatar Aug 16 '22 11:08 jcs090218

Thanks for the report. Could you try with emacs -q and check if the problem remains?

rougier avatar Aug 31 '22 10:08 rougier

Does this look correct? This is in emacs -q on Windows 10.

Image 1

jcs090218 avatar Aug 31 '22 11:08 jcs090218

I think the bug is caused by marginalia-mode with the following config,

(setq marginalia-align 'right)  ; no bug if it's 'left

jcs090218 avatar Aug 31 '22 12:08 jcs090218

Do you know what does it do with right alignment?

rougier avatar Sep 21 '22 07:09 rougier

Could fonts be causing this? I had a very similar problem on macOS when using Roboto Mono at height 140. Changing it to either 130 or 150 seems to make the problem go away.

jah-purdue avatar May 10 '23 21:05 jah-purdue

Problem might be a miscalculation with fringes an margins. Coudl you try with no fringe and no margin just to be sure (and no line numbers) ?

rougier avatar May 22 '23 14:05 rougier

I get this issue too. But, if I set minibuffer-header-face's font to Noto Sans, it seems OK. if I set minibuffer-header-face's font to JetBrainsMono, the minibuffer-header-line exceed window-width, not ok.

(use-package minibuffer-header
  :custom-face
  (minibuffer-header-face
	((t (:overline "#A15ABD"
		  :family "Noto Sans"
		  :background "#141414"))))
  :config
  (minibuffer-header-mode 1)
  )

eval-exec avatar Oct 15 '24 16:10 eval-exec

I've made a lot of progress in fringe/margin/text/window alignment with the nano-modeline rewrite. Probably this code could be easily adapted.

Do any of you woudl have time for a PR?

rougier avatar Oct 21 '24 14:10 rougier