mastodon-alt icon indicating copy to clipboard operation
mastodon-alt copied to clipboard

Published 20 hours ago • verified publisher icon rougier

base-toot-id becomes base-item-id in mastodon.el 1.0.13

Open csantosb opened this issue 1 year ago • 4 comments

csantosb avatar Dec 28 '23 18:12 csantosb

Can you give some more details?

rougier avatar Jan 09 '24 20:01 rougier

That's right, base-toot-id was renamed to base-item-id here: https://codeberg.org/martianh/mastodon.el/commit/574c17c4bdfe43a3081ddcbde4452dd477929c02

I've just found that problem because since this commit mastodon-tl--thread uses the following to get an id:

(mastodon-tl--property 'base-item-id :no-move)

See line 1783 in mastodon-tl.el in the linked diff.

The current version of mastodon-alt still uses base-toot-id: https://github.com/rougier/mastodon-alt/blob/bd22a07b92cb4914b298d57e78fc9c4ecd57bdd5/mastodon-alt.el#L691

So at least mastodon-tl--thread doesn't work with mastodon-alt. This PR fixes that.

SqrtMinusOne avatar Jan 18 '24 18:01 SqrtMinusOne

I'd propose merging #22 because it supersedes this PR.

#22 also fixes mastodon--toot-reply in thread view.

SqrtMinusOne avatar Jan 21 '24 16:01 SqrtMinusOne

Thanks. I think I already merged a PR for that. Can you compare your PR with the current version?

rougier avatar Jan 22 '24 12:01 rougier