rouge icon indicating copy to clipboard operation
rouge copied to clipboard

Add lexer for the Logtalk programming language

Open pmoura opened this issue 10 years ago • 11 comments

pmoura avatar Sep 07 '15 06:09 pmoura

Does the optimizer in the regular expression implementation do a job as good as hand-optimized regular expressions?

pmoura avatar Sep 27 '15 22:09 pmoura

Yes.

jneen avatar Nov 06 '15 03:11 jneen

Requested changes applied.

pmoura avatar Sep 20 '16 18:09 pmoura

This should be ready for merging. Let me know if there's any issue remaining.

pmoura avatar Jan 03 '17 11:01 pmoura

@pmoura I apologize - I'm still getting used to this github review interface, so I left comments that you never saw. They should be visible now.

jneen avatar Jan 27 '17 17:01 jneen

There can be no space(s) between a predicate name and its open parenthesis. For example, assertz(...) is call to the standard built-in predicate assertz/1. assertz ( is a syntax error (unless the atom assertz is declared as a prefix operator, which is highly unlikely).

pmoura avatar Jan 27 '17 17:01 pmoura

Fair enough for that bit :]

jneen avatar Jan 27 '17 17:01 jneen

W.r.t. states, my understanding (please correct me if I'm wrong) is that a directive pops to :basic, which then allows it to be followed by e.g. another directive. So, the fix you hint is that is not necessary to mix :directives into :root as we're already mixing :basic? Which would suggest that we could simply replace :basic with :root.

pmoura avatar Jan 27 '17 18:01 pmoura

I'm not sure of the fix, but it's dangerous to pop from root, since the state stack can never be empty.

jneen avatar Jan 27 '17 20:01 jneen

I'm not sure of the fix, but it's dangerous to pop from root, since the state stack can never be empty.

I believe that's now fixed: :directives is no longer mixed into :root. The included comprehensive sample file is highlighted correctly without any errors.

pmoura avatar Jan 02 '24 21:01 pmoura

P.S. Should I squash all commits into a single one for merging?

pmoura avatar Jan 02 '24 21:01 pmoura