rouge icon indicating copy to clipboard operation
rouge copied to clipboard

JavaScript private fields are being formatted as error

Open sphinxc0re opened this issue 1 year ago • 3 comments

Name of the lexer JavaScript

Code sample

export class DataPoint {
  #time = $.source($.proxy(new Date()));

  get time() {
    return $.get(this.#time);
  }
}

image

Those fields should ideally be part of the identifier

sphinxc0re avatar Jan 29 '24 10:01 sphinxc0re

Any word on this? We use rouge via GitLab and TypeScript files are a mess of random meaningless highlights that distract from the actual code diff

wedgebert avatar Oct 17 '24 14:10 wedgebert

@sphinxc0re @wedgebert I believe this https://github.com/rouge-ruby/rouge/pull/2076 will address the issue. I will have to push a new release.

tancnle avatar Oct 17 '24 15:10 tancnle

That's awesome, thanks!

wedgebert avatar Oct 17 '24 15:10 wedgebert