rouge icon indicating copy to clipboard operation
rouge copied to clipboard

With HTML or HTMLLegacy/wrap=false, <pre> / <code> are replaced with <divs>

Open dabrahams opened this issue 4 years ago • 3 comments

According to the README: setting wrap: false with the HTMLLegacy formatter, or simply using the HTML formatter, is supposed to not introduce any new <div>s. Apparently, though, it actually removes <pre>/<code> and still leaves new <div> tags in place.

Steps to reproduce the behavior: See http://dabrahams.github.io/pages-test/ which is rendered from https://github.com/dabrahams/pages-test

dabrahams avatar Oct 01 '21 02:10 dabrahams

@dabrahams Have you verified that it is not Github Pages that is adding a wrapper?

I suggest either trying to reproduce this with rougify or opening an issue with Github Pages, I have no idea how their _config.yml syntax is applied, and I do know they do a lot of custom processing to support legacy builds.

jneen avatar Oct 01 '21 02:10 jneen

Yes, I have verified that this happens when I run Jekyll in a local docker container.

I don't know how to make rougify accept the formatter setting:

$ rougify highlight -f HTMLLegacy -F wrap=false -
unknown formatter preset HTMLLegacy

dabrahams avatar Oct 01 '21 04:10 dabrahams

This issue has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days. If you would like this issue to remain open, please reply and let us know if the issue is still reproducible.

stale[bot] avatar Nov 02 '22 04:11 stale[bot]