Fredrik Roubert
Fredrik Roubert
For the first step here, I'd very much like to use the well-tested and type-safe standard library `std::variant`, as that means less new code that needs to be written, adding...
> I believe that this changes from compile-time u_strlen() to runtime u_strlen(). Why would it do that and why would UTF-16 string literals be different from all other string literals?
Let's check what the compiler actually does. I just wrote this trivial piece of test code: ```c++ #include int do_something(std::u16string_view s); int test1() { return do_something(u"foo"); } int test2() {...
> I just wrote this trivial piece of test code: But `icu::UnicodeString` is a lot more complex and has a frankly bewildering amount of overloaded constructors and no easily copy-pasteable...
> I am assuming here that we are still going through u16string_view via the new overload; That was my assumption too, that seemed to be the logical thing to do,...
> As Fredrik wrote, this is very unusual and thus counterintuitive to people familiar with modern C++; documentation won’t fix that. As we're now at least two who share this...
> @roubert ready to un-draft & merge? The CI is still broken, waiting on PR #3144.
With PR #3106 and PR #3144 now both successfully merged, work can now proceed here. The changes in this PR now really do what I had thought that they would...
[compile_commands.json](https://github.com/rizsotto/Bear/files/15076883/compile_commands.json)
Have you had the chance to look into this and can you confirm that it's an issue with Bear (that would be useful to fix)?