Even Rouault

Results 1301 comments of Even Rouault

``` D:\a\gdal\gdal\ogr\ogrsf_frmts\openfilegdb\ogropenfilegdbdatasource_write.cpp(1941,34): error C2220: the following warning is treated as an error [D:\a\gdal\gdal\build\ogr\ogrsf_frmts\openfilegdb\ogr_OpenFileGDB.vcxproj] D:\a\gdal\gdal\ogr\ogrsf_frmts\openfilegdb\ogropenfilegdbdatasource_write.cpp(1941,34): warning C4305: 'return': truncation from 'int' to 'bool' [D:\a\gdal\gdal\build\ogr\ogrsf_frmts\openfilegdb\ogr_OpenFileGDB.vcxproj] D:\a\gdal\gdal\ogr\ogrsf_frmts\openfilegdb\ogropenfilegdbdatasource_write.cpp(1943,9): warning C4305: 'return': truncation from 'int'...

Linting issue in autotest suite. In your repository, you'll have to enable ``pre-commit`` to run locally some of those linting checks & have automatic fixes being applied before committing. See...

@nyalldawson gentle ping that this PR requires further actions

Pull request rebased on top of latest master, with linting issues in autotest solved

Not related to libjxl specific expectations, but one tricky aspect of libtiff API to have in mind is that is you use nbits != 8, 16, 32, libtiff expects samples...

> I was as we speak browsing through the libtiff code to see where I could find such a function :) it wouldn't probably hurt to move that part of...

> Was this what you had in mind ? perhaps not completely. What I had in mind is that the left/right shifting to please libjxl expectation should be done by...

> We do have access to basic_info.bits_per_sample in the predecode phase, so I believe it can be set from here. yes but the predecode phase is only triggered by a...

Storing the source in the RPC metadata domain could cause inconveniences when it is copied to other formats or other operations where we don't really want to keep that information...