Dan Rose

Results 564 comments of Dan Rose

The serialize/deserialize implementations seem fishy to me. ~~I don't see a reason not to use [structuredClone](https://developer.mozilla.org/en-US/docs/Web/API/structuredClone). Could probably result in some perf gains too.~~ Edit: I missed the obvious; this...

This issue should be higher priority. As a new contributor, it's hard to tell if I broke anything when I don't know what's broken to start with!

@HarelM Yes, this project is community driven. And demo pages are a good example of something that discourages my (and probably others') ability to confidently contribute. Unfortunately, they debug pages...

@HarelM, no worries! You have been very welcoming and I'm not offended at all by this or any code review comments. I hope that I haven't been out of line...

It even fails if the type is just an otherwise legal name in parentheses, or a literal object type! ```ts repro interface A{} // works interface B extends A {}...

> The error really does mean exactly what it says 🙃 lol. I think it's a little more confusing because types are *not* nominal. That is, the interface extends "the...

This also causes a leak of type parameters: ```ts repro type ArrayIteratorMethod = (this: This) => IterableIterator type MyStringArray = { [k:number]: string, length: number, [Symbol.iterator]: ArrayIteratorMethod } const y...

In my particular case, I have an object that types as a `PerspectiveCamera | OrthographicCamera` so it would help there. But just about everything in this API has such a...

Actually, `in` guard DOES work, which seems kind of funny, since it's a less discerning check! ```ts if ('isOrthographicCamera' in camera){ // ... } ```

It seems odd to me that the `` element was omitted even though it was [present in vue 2](https://github.com/vuejs/vue/blob/305e4ae9dce0a05a422b675ff555f17878e86063/packages/compiler-sfc/src/templateCompilerModules/assetUrl.ts#L23). I don't see a reason why the attributes added in this...